-
Notifications
You must be signed in to change notification settings - Fork 1
Zmq freerun #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zmq freerun #129
Conversation
32afc4d to
1da4c32
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
0db6288 to
3d0c251
Compare
…rs are ending and that shouldn't break running lol.
d571a7f to
abada36
Compare
| nonlocal finished | ||
|
|
||
| finished = True | ||
| with work_ready: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this ok to be not nonlocal? clearly it's working since tests are passing but why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what you mean? this is nonlocal because it's referring to finished which is defined in the outer function scope, and we are modifying it, so it needs to be nonlocal (otherwise assigning to it would just create finished in the inner _done scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry i was asking about work_ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha my b. No thats fine since we dont rebind work_ready
Fix: #69
Fix: #96
Builds on: #127
Opening as an early draft just to track progress.
currently at a point where the iterators exhaust and prematurely close the runner
initmethod.itermethod to iterate through resultsrunmethod with unlimited nrunmethod with fixed nrunmethod withiterAlong the way we resolved a few other things
📚 Documentation preview 📚: https://noob--129.org.readthedocs.build/en/129/